Fix -updateRCUSchemaPassword failed when it has new custom datasource #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l but at the same time there is a new datasource
rakillen
approved these changes
Apr 21, 2021
CarolynRountree
approved these changes
Apr 22, 2021
ddsharpe
reviewed
Apr 22, 2021
| @@ -54,6 +54,12 @@ def update_rcu_password(self): | |||
| for ds_name in ds_names: | |||
| location = deployer_utils.get_jdbc_driver_params_location(ds_name, self.aliases) | |||
| password_location = LocationContext(location) | |||
| list_path = self.aliases.get_wlst_list_path(location) | |||
| if not self.wlst_helper.path_exists(list_path): | |||
| # For update case when a new custom data source has not be persisted | |||
There was a problem hiding this comment.
"data source has not be persisted" => "data source has not been persisted"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the failure when updating a jrf domain's rcu password but at the same time adding a new datasource.